Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative stopwatch times #11631

Merged
merged 2 commits into from Dec 13, 2022
Merged

fix negative stopwatch times #11631

merged 2 commits into from Dec 13, 2022

Conversation

dixler
Copy link
Contributor

@dixler dixler commented Dec 12, 2022

Description

Fixes #11188

This PR fixes negative times showing up on the update display. This was caused by operations that did not emit a resource output event using the end time for the previous operation if it existed. This change clears the old end time if it exists.

TODO

  • write test
  • find and implement fix
  • write changelog entry

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Dec 12, 2022

Changelog

[uncommitted] (2022-12-12)

Bug Fixes

  • [cli/display] Fixes negative durations on update display.
    #11631

@dixler dixler force-pushed the dixler/11188/negative-timings branch from ba0b20c to d8b2671 Compare December 12, 2022 19:31
@dixler dixler force-pushed the dixler/11188/negative-timings branch from f2814fa to a66ccea Compare December 12, 2022 20:19
@dixler dixler marked this pull request as ready for review December 12, 2022 22:01
@dixler
Copy link
Contributor Author

dixler commented Dec 13, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 13, 2022

Build succeeded:

@bors bors bot merged commit feac805 into master Dec 13, 2022
@bors bors bot deleted the dixler/11188/negative-timings branch December 13, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative timings show up when running pulumi destroy with --refresh=true
3 participants