Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for optional/ Ptr types within Unions [go/programgen] #11635

Merged
merged 1 commit into from Dec 13, 2022
Merged

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Dec 12, 2022

Fixes #11496
This fixes a bug in Go programgen where optional outputs are not returned as pointers (example in ticket)

@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-12-12)

Bug Fixes

  • [programgen/go] Check for optional/ Ptr types within Union types. This fixes a bug in Go programgen where optional outputs are not returned as pointers.
    #11635

@aq17 aq17 requested a review from justinvp December 12, 2022 21:26
@aq17 aq17 force-pushed the aqiu/11496 branch 2 times, most recently from 8217977 to fabeda6 Compare December 12, 2022 23:48
@aq17
Copy link
Contributor Author

aq17 commented Dec 13, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 13, 2022

Build succeeded:

@bors bors bot merged commit 94ef784 into master Dec 13, 2022
@bors bors bot deleted the aqiu/11496 branch December 13, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting optional property accessor fails to compile
3 participants