Make the PluginMapper lazy #11639
Merged
Make the PluginMapper lazy #11639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-12-14)Bug Fixes
|
Frassle
force-pushed
the
fraser/lazyPluginMapper
branch
2 times, most recently
from
4b1df37
to
5534ad3
Compare
Frassle
force-pushed
the
fraser/lazyPluginMapper
branch
from
5534ad3
to
04a24f3
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. Makes the PluginMapper lazy so for yaml we don't have to load every plugin in ~/.pulumi/plugins.
We don't load any provider plugins until we need to load an conversion mapping that we don't yet have.
Once we find the first provider that supplies a conversion mapping we stop looking for any more.
The only other improvement to make here that I think is possible is to shut down the providers after asking for their conversion mapping data. But that needs a rejig of how plugin.Host works, which is hard to do right now as it's a public api.