Don't panic when annotating with missing objects

[iwahbe]

Fixes #11658

I have been unable to repro the bug, but since annotateObjectProperties is advisory, I'm adding some defensive nil checks.

[pulumi-bot]

Changelog

[uncommitted] (2022-12-15)

Bug Fixes

• [programgen] Don't panic on some empty objects
  #11660

[Zaid-Ajaj]

LGTM. Just curious though:

In this expression

schemaObjectType, ok := schemaType.(*schema.ObjectType);

if ok && schemaObjectType == nil doesn't that something went wrong in the schema binding?

[iwahbe]

LGTM. Just curious though:

In this expression

schemaObjectType, ok := schemaType.(*schema.ObjectType);

if ok && schemaObjectType == nil doesn't that something went wrong in the schema binding?

I think so but I'm not 100% sure, Go has some weird pointer-type semantics. PCL needs to work on invalid inputs though, so we still need the check.

[iwahbe]

bors r+

[bors]

Build succeeded:

• bors-ok