Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert support for projects in the Self-Managed backend #12052

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Feb 2, 2023

Temporarily reverting this to keep master in a releasable state while we finalize the design.

As it was, the syntax pulumi stack select foo/bar could mean fundamentally different things based on what backend you're logged into. In the Service backend, the foo is the org. In the Self-Managed backend, the foo would be the project name. Moreover, in the Service backend, there is one "fully-qualified" name, and all the others are just shorthands. But this wouldn't be true in the Self-Managed backend where bar represents a fundamentally different stack than foo/bar. This makes it hard to explain what stack identities are. Self-Managed has been a pure subset of what Service supported in terms of stack identities. If we went with this design, it would be a partially overlapping, but inconsistent subset/superset.

We're discussing some design alternatives that would make stack identities in the Self-Managed backend more consistent with the Service backend, and will reintroduce the changes with the adjusted design soon.

@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 2, 2023
@justinvp justinvp requested a review from a team February 2, 2023 23:34
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Feb 2, 2023

Changelog

[uncommitted] (2023-02-03)

@justinvp
Copy link
Member Author

justinvp commented Feb 3, 2023

bors merge p=1

@abhinav
Copy link
Contributor

abhinav commented Feb 3, 2023

Superseded by #12066

@abhinav abhinav closed this Feb 3, 2023
@abhinav abhinav deleted the justin/filestateprojects branch February 3, 2023 22:14
@abhinav abhinav restored the justin/filestateprojects branch February 3, 2023 22:15
@abhinav abhinav reopened this Feb 3, 2023
@abhinav
Copy link
Contributor

abhinav commented Feb 3, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 3, 2023

Already running a review

@abhinav
Copy link
Contributor

abhinav commented Feb 3, 2023

Accidentally closed the wrong PR

@bors
Copy link
Contributor

bors bot commented Feb 3, 2023

Build succeeded:

@bors bors bot merged commit b2b90f8 into master Feb 3, 2023
@bors bors bot deleted the justin/filestateprojects branch February 3, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants