[sdk/nodejs] Fix provider for resource methods

[justinvp]

The Resource class in the Node.js SDK has the following internal property:

/** @internal */
readonly __prov?: ProviderResource;

When a resource is created, the provider specified for the resource is stored in this property. If it is set, it is passed along in the Call request when a method is called on the resource.

Prior to #13282, the property was only set for custom resources in Resource's constructor:

this.__prov = custom ? opts.provider : undefined;

With #13282, it was changed to also store the value for remote components:

- this.__prov = custom ? opts.provider : undefined;
+ this.__prov = custom || remote ? opts.provider : undefined;

This regressed the behavior when calling a method on a remote component that had an explicit provider that wasn't the component provider, but some other provider (e.g. AWS provider) specified as:

const component = new MyRemoteComponent("comp", {
}, { provider: awsProvider });

The awsProvider was being stored in Resource.__prov, and when making the method call on the resource, it would try to invoke Call on the AWS provider, rather than calling the remote component provider's Call, which resulted in an error.

Note that specifying the AWS provider using the more verbose providers: [awsProvider] works around the issue.

The fix is to only set __prov if the provider's package is the same as the resource's package. Otherwise, don't set it, because the user is specifying a provider with the provider: awsProvider syntax as shorthand for providers: [awsProvider].

Fixes #13777

[pulumi-bot]

Changelog

[uncommitted] (2023-08-30)

Bug Fixes

• [sdk/nodejs] Fix provider used for resource methods
  #13796

[dixler]

LGTM