allow retries for encrypt/decrypt API calls #15600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default our HTTP client retries all GET requests. However these post requests are also idempotent, as we just expect to encrypt/decrypt a single value, without changing anything on the server side. Retry them, so network errors won't abort the pulumi program.
tgummerer
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-03-05)Bug Fixes
|
tgummerer
removed
the
impact/no-changelog-required
Frassle
approved these changes
Mar 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
### Features - [pkg] Make schema.NewPluginLoader respect PULUMI_DEBUG_PROVIDERS, which enables Pulumi YAML programs to work correctly with this feature [#15526](#15526) - [sdk/python] Add support for asynchronous invokes via a new `invoke_async` function [#15602](#15602) - [sdkgen/dotnet] Support for non-overlay components in codegen for pulumi-kubernetes provider [#15490](#15490) ### Bug Fixes - [backend/service] Make decrypt/encrypt network calls retryable to help work around network hiccups [#15600](#15600) - [cli/new] Strip credentials and query strings from template URLs saved to project [#15586](#15586) - [engine] Fix an issue where snapshots could become invalid when doing a targeted up [#15476](#15476) - [sdk/python] Fix determining plugins for old packages in the Python language host [#15576](#15576) - [pkg/testing] Make ProgramTest use a temporary PULUMI_HOME for each test [#15568](#15568) - [sdkgen/dotnet] Codegen fix for resources without constant input properties [#15488](#15488)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Draft changelog:
### Features
- [auto/{go,nodejs,python}] Add support for suppress progress and
suppress outputs parameters in the Automation API
[#15596](#15596)
- [pkg] Make schema.NewPluginLoader respect PULUMI_DEBUG_PROVIDERS,
which enables Pulumi YAML programs to work correctly with this feature
[#15526](#15526)
- [sdk/dotnet] Update dotnet language host to 3.60.0
[#15609](#15609)
- [sdk/nodejs] Add experimental support to the NodeJS SDK for the new
transforms system.
[#15532](#15532)
- [sdk/python] Add support for asynchronous invokes via a new
`invoke_async` function
[#15602](#15602)
- [sdkgen/dotnet] Support for non-overlay components in codegen for
pulumi-kubernetes provider
[#15490](#15490)
### Bug Fixes
- [cli] Fix a panic when the secrets provider is missing from the
deployment snapshot
[#15599](#15599)
- [backend/service] Make decrypt/encrypt network calls retryable to help
work around network hiccups
[#15600](#15600)
- [cli/new] Strip credentials and query strings from template URLs saved
to project
[#15586](#15586)
- [engine] Fix an issue where snapshots could become invalid when doing
a targeted up
[#15476](#15476)
- [pkg/testing] Make ProgramTest use a temporary PULUMI_HOME for each
test
[#15568](#15568)
- [sdkgen/dotnet] Codegen fix for resources without constant input
properties
[#15488](#15488)
- [sdk/nodejs] Properly capture node:crypto and global.crypto in node
19+
- [sdk/python] Fix determining plugins for old packages in the Python
language host
[#15576](#15576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default our HTTP client retries all GET requests. However these post requests are also idempotent, as we just expect to encrypt/decrypt a single value, without changing anything on the server side. Retry them, so network errors won't abort the pulumi program.
There's also some log decryption events that might be retryable, but I'm not sure about them, so I left them alone for now.
Fixes #15236