Ensure package generation for Go SDKs doesn't panic when encountering overly nested arrays or maps of primitive types #15680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-03-14)Bug Fixes
|
This was referenced Mar 14, 2024
Zaid-Ajaj
force-pushed
the
zaid/fix-panic-on-nested-arrays-in-go
branch
from
8044fce
to
1f1e411
Compare
This was referenced Mar 14, 2024
justinvp
approved these changes
Mar 14, 2024
| Directory: "regress-go-15478", | ||
| Description: "Regress pulumi/pulumi#15478 affecting Go ensuring SDK-gen doesn't panic", | ||
| Skip: allLanguages.Except("go/any"), | ||
| SkipCompileCheck: codegen.NewStringSet(golang), |
There was a problem hiding this comment.
Should we add a comment here? We're deliberately skipping right now because we don't expect it to be able to compile due to missing deeply nested container types in the core Go SDK.
There was a problem hiding this comment.
Added a comment ✅
Frassle
reviewed
Mar 14, 2024
| } | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
should probably add map/map/map as well
…ly nested arrays or maps of primitive types
Zaid-Ajaj
force-pushed
the
zaid/fix-panic-on-nested-arrays-in-go
branch
from
40d83a5
to
c0bb9d7
Compare
This was referenced Mar 14, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
### Features - [auto/go] Support remote deployment executor image [#15697](#15697) ### Bug Fixes - [engine] Test and fix the engine filling in property dependencies to provider constructs [#15675](#15675) - [sdkgen/go] Ensure package generation for Go doesn't panic when encountering overly nested arrays or maps of primitive types [#15680](#15680)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15478 where sdk-gen should no longer panic when encountering overly nested arrays or maps of primitive types. The generated code still fails to compile but validation can be added later to cover cases where we are missing primitives in the core SDK to handle overly nested type definitions.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change