Use new API for deployments #15684
Merged
Use new API for deployments #15684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-16)Features
|
komalali
force-pushed
the
komal/update-deployments
branch
from
75fde30
to
3a48469
Compare
komalali
force-pushed
the
komal/update-deployments
branch
3 times, most recently
from
afe2445
to
7a0ddb6
Compare
komalali
force-pushed
the
komal/update-deployments
branch
from
d05acba
to
897538c
Compare
komalali
force-pushed
the
komal/update-deployments
branch
from
897538c
to
4ce92c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Remote Automation API to use the new stable URLs for the Deployments API. Adds support for
inheritSettingsto allow inheriting deployment settings pre-existing on the stack.I've tested this manually by editing the automation-api-examples for remote deployments, but not sure of a great way to add automated tests since automation api doesn't yet have support for setting deployment settings.
EDIT: I considered just setting up a static stack for this but abandoned it because of concerns around parallel runs. We can add automated tests for this once we support creating deployment settings with automation api (coming soon).
Fixes #12739
Fixes #15518
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change