Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto/go] Support for remote deployment executor image #15697

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

komalali
Copy link
Member

@komalali komalali commented Mar 15, 2024

Description

Adds Go Automation API support for specifying custom executor images for remote deployments.

Part of: #15693

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@komalali komalali changed the title go automation api support for remote deployment executor image [auto/go] Support for remote deployment executor image Mar 15, 2024
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Mar 15, 2024

Changelog

[uncommitted] (2024-03-15)

Features

  • [auto/go] Support remote deployment executor image
    #15697

Copy link
Collaborator

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy to get this merged now and to get it into a release.

Does this need to be added to the other languages as well though soon?

@tgummerer tgummerer added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit 5ced672 Mar 15, 2024
48 checks passed
@tgummerer tgummerer deleted the komal/custom-executor branch March 15, 2024 07:40
github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2024
Tentative changelog:

### Features

- [auto/go] Support remote deployment executor image
  [#15697](#15697)


### Bug Fixes

- [sdkgen/go] Ensure package generation for Go doesn't panic when
encountering overly nested arrays or maps of primitive types
  [#15680](#15680)
@tgummerer tgummerer mentioned this pull request Mar 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2024
### Features

- [auto/go] Support remote deployment executor image
  [#15697](#15697)


### Bug Fixes

- [engine] Test and fix the engine filling in property dependencies to
provider constructs
  [#15675](#15675)

- [sdkgen/go] Ensure package generation for Go doesn't panic when
encountering overly nested arrays or maps of primitive types
  [#15680](#15680)
@komalali
Copy link
Member Author

@tgummerer yeah we should port this over to the other languages - I didn't quite have time to hammer them all out so just focused on the one folks were waiting on for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants