Make function serialization work on typescript 4 and 5 #15761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-03-27)Features
|
julienp
force-pushed
the
julienp/reorganize-closure-tests
branch
from
b0bf480
to
cafa450
Compare
julienp
force-pushed
the
julienp/closures-on-ts4-and-5
branch
from
3235592
to
052b12a
Compare
julienp
commented
Mar 25, 2024
| @@ -1,13 +1,17 @@ | |||
| exports.handler = __f0; | |||
|
|
|||
| var __deploymentOnlyModule = {}; | |||
There was a problem hiding this comment.
Changes here are due to export * compiling slightly different in 3.9 and later.
julienp
force-pushed
the
julienp/closures-on-ts4-and-5
branch
from
f919e1e
to
e45ca6c
Compare
julienp
force-pushed
the
julienp/reorganize-closure-tests
branch
5 times, most recently
from
6ac40d4
to
e138f20
Compare
julienp
force-pushed
the
julienp/closures-on-ts4-and-5
branch
from
e45ca6c
to
09f1405
Compare
julienp
commented
Mar 25, 2024
| with({ __awaiter: __f0, f: __f, this: undefined, arguments: undefined }) { | ||
|
|
||
| return function /*f*/(_a) { | ||
| return __awaiter(this, arguments, void 0, function* ({ whatever }) { }); |
There was a problem hiding this comment.
Before 5.2 the arguments were not passed into __awaiter microsoft/TypeScript#56296
julienp
commented
Mar 25, 2024
| // This test validates that the typescript version used by the closure tests | ||
| // is the same as the one used by the pulumi package and that we are testing | ||
| // what we think we are testing ... | ||
| it(`resolve to the correct typescript version within the pulumi package`, |
There was a problem hiding this comment.
Turns out I was running the tests for a while where we had node_modules/typescript at the expected version, but also node_modules/@pulumi/pulumi/node_modules/typescript on 3.8.3 ... This seems somewhat easy to break, so this tests ensures we have the correct test setup.
julienp
force-pushed
the
julienp/closures-on-ts4-and-5
branch
from
09f1405
to
c287c32
Compare
justinvp
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
I noticed integration is misspelled in the filename.
julienp
force-pushed
the
julienp/closures-on-ts4-and-5
branch
from
c287c32
to
199e3ea
Compare
julienp
force-pushed
the
julienp/closures-on-ts4-and-5
branch
from
199e3ea
to
3e7c264
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Tentative changelog: ### Features - [docs] Implement constructor syntax examples for every resource in typescript, python, csharp and go [#15624](#15624) - [docs] Implement YAML constructor syntax examples in the docs [#15791](#15791) - [engine] Send output values with property dependency information to transform functions [#15637](#15637) - [engine] Add a --continue-on-error flag to pulumi destroy [#15727](#15727) - [sdk/go] Make `property.Map` keyed by `string` not `MapKey` [#15767](#15767) - [sdk/nodejs] Make function serialization work with typescript 4 and 5 [#15761](#15761) - [sdk/python] Improve the error message when depends_on is passed objects of the wrong type [#15737](#15737) ### Bug Fixes - [auto/{go,nodejs,python}] Make sure to read complete lines before trying to deserialize them as engine events [#15778](#15778) - [cli/plugin] Fix installing local language plugins on Windows [#15715](#15715) - [engine] Don't delete stack outputs on failed deployments [#15754](#15754) - [engine] Fix a panic when updating provider version in a run using --target [#15716](#15716) - [engine] Handle that Assets & Archives can be returned from providers without content. [#15736](#15736) - [engine] Fix the engine trying to delete a protected resource caught in a replace chain [#15776](#15776) - [sdkgen/docs] Add missing newline for `Coming soon!` [#15783](#15783) - [programgen/dotnet] Fix generated code for a list of resources used in resource option DependsOn [#15773](#15773) - [programgen/{dotnet,go}] Fixes emitted code for object expressions assigned to properties of type Any [#15770](#15770) - [sdk/go] Fix lookup of plugin and program dependencies when using Go workspaces [#15743](#15743) - [sdk/nodejs] Export automation.tag.TagMap type [#15774](#15774) - [sdk/python] Wait only for pending outputs in the Python SDK, not all pending asyncio tasks [#15744](#15744) ### Miscellaneous - [sdk/nodejs] Reorganize function serialization tests [#15753](#15753) - [sdk/nodejs] Move mockpackage tests to closure integration tests [#15757](#15757)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on top of #15753
Fixes #15735
There are a couple breaking changes in the typescript API that we use in
sdk/nodejs/runtime/closure/rewriteSuper.ts. This PR adds a shim that is used to bridge the differences and versions the snapshots where needed.This does not make typescript a peer dependency yet. Instead the tests force a specific version to be used via yarn resolutions.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change