revert readlines fix for nodejs #15798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-03-27)Bug Fixes
|
tgummerer
force-pushed
the
tg/revert-nodejs-fix
branch
2 times, most recently
from
38b8c93
to
d463a15
Compare
Frassle
approved these changes
Mar 27, 2024
tgummerer
force-pushed
the
tg/revert-nodejs-fix
branch
from
d463a15
to
f9345e8
Compare
I've been trying to add a test for this, but it looks like the library actually deals with splitting the lines correctly. Given that I don't want to accidentailly hide any potential issues and bring the logging back. The test can still be useful for the future, so I left it there.
tgummerer
force-pushed
the
tg/revert-nodejs-fix
branch
from
f9345e8
to
a8dff57
Compare
Merged
tgummerer
changed the title
|
Not sure what's happening with the test here, but it seems to get stuck after it finished running somehow. I removed it for now and just did the revert of the code so we can get it in for the release, and then I can investigate the test properly tomorrow. |
This test is blocking after it finished somehow, so let's remove it for now, so we can get the revert through the merge queue.
tgummerer
force-pushed
the
tg/revert-nodejs-fix
branch
from
d9ab17f
to
a2321cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to add a test for this, but it looks like the library actually deals with splitting the lines correctly. Also reading back through the issue again, it seems like the lines are missing the start of the line, not the end, so this fix wouldn't work. Given that I don't want to accidentally hide any potential issues and bring the logging back.
The test can still be useful for the future, so I left it there.
I'm reopening #6768 as well.