Save component resources as parents #15846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-08)Bug Fixes
|
Frassle
force-pushed
the
fraser/componentTransforms
branch
from
96c74f8
to
8a02737
Compare
Frassle
force-pushed
the
fraser/componentTransforms
branch
from
8a02737
to
9528448
Compare
justinvp
reviewed
Apr 8, 2024
Comment on lines
+1521
to
+1523
| if pending, ok := rm.pendingTransforms[pendingKey]; ok { | ||
| transforms = pending | ||
| } else { |
There was a problem hiding this comment.
What happens if the program specified transforms for the remote component and then the implementation of the remote component (inside Construct) also adds more transforms to its request?
There was a problem hiding this comment.
Currently we ignore the transforms set inside the component. We could append them to the pending list, but need to be careful about duplication and ordering.
lunaris
approved these changes
Apr 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15843.
This tracks parent information separate from Goal information (as that was only generated and saved for custom, not component, resources).
We also need to keep track of the transform list between the first RegisterResource starting a remote component construction and the remote component actually registering itself. This means we save the transform list correctly once the component is registered inside the remote process allowing other resource registrations in the remote process to see that saved transform list.
If we just wait till the Construct call is done then none of the inner children pick up the transform list.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change