allow unknowns in apply during update #15898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently during updates we try to make the values known during apply, even if they are marked unknown. This results in knows that should really still be unknown. Note that this behaviour is currently encoded in tests, which also needed to change.
Changelog[uncommitted] (2024-04-10)Features
|
tgummerer
commented
Apr 10, 2024
| assert.strictEqual(await r.promise(), "inner"); | ||
| }); | ||
|
|
||
| it("propagates secret on unknown known output", async () => { |
There was a problem hiding this comment.
This feels a bit unintuitive, but these tests don't make sense if we are allowing unknown outputs. There will not be any value, so there's nothing to be secret.
Frassle
reviewed
Apr 10, 2024
Yup added that now. I also did the same for Python now. Go seems to behave differently already if I read that right, so I didn't make any changes there yet. |
Frassle
approved these changes
Apr 10, 2024
tgummerer
force-pushed
the
tg/remove-nodejs-apply-logic
branch
from
4748af6
to
fcc5c3a
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Tentative changelog: ### Features - [cli] Support always fully qualifying stack names in CLI output [#15857](#15857) - [cli] Add --no-plugins and --no-dependencies to `pulumi install` [#15910](#15910) - [docs] Implement Java constructor syntax examples [#15805](#15805) - [sdk/nodejs] Make TypeScript and ts-node optional peer dependencies to allow using user specified versions [#15622](#15622) - [sdk/{nodejs,python}] Allow apply to have unknown values during updates [#15898](#15898) - [sdk/python] Adds 'typeChecker' runtime option to the Python language host [#15725](#15725) ### Bug Fixes - [auto] Tolerate missing stack and bookkeeping files in ProgramTest. [#15863](#15863) - [cli] Fix a panic when user's home directory could not be looked up [#15872](#15872) - [cli] Fix some commands that didn't respect `--disable-integrity-checking` - [programgen/dotnet] Removes trailing whitespace from emitted DependsOn resource option expressions [#15892](#15892) - [auto/go] Avoid flakyness when reading the event log from pulumi commands [#15856](#15856) - [sdk/go] Fix Provider and Providers options in Go transform functions [#15885](#15885) - [sdk/nodejs] Handle serialization of aliases for well known native functions [#15873](#15873) - [sdk/nodejs] Correctly serialise functions whose code would make use of reserved identifiers [#15879](#15879) - [sdk/nodejs] Serialize function values obtained from Function.bind [#15887](#15887) - [sdk/python] Improve types of getters in Python SDK [#15865](#15865) - [sdkgen/{dotnet,go}] Fixes SDK-generation when referencing shared types in config variables [#15772](#15772) ### Miscellaneous - [sdk/nodejs] Update builtin module list for function serialization [#15830](#15830) - [sdk/nodejs] Set package.json engines to node >= 18 [#15845](#15845)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
### Features - [cli] Support always fully qualifying stack names in CLI output [#15857](#15857) - [cli] Add --no-plugins and --no-dependencies to `pulumi install` [#15910](#15910) - [docs] Implement Java constructor syntax examples [#15805](#15805) - [sdk/nodejs] Make TypeScript and ts-node optional peer dependencies to allow using user specified versions [#15622](#15622) - [sdk/{nodejs,python}] Allow apply to have unknown values during updates [#15898](#15898) - [sdk/python] Adds 'typeChecker' runtime option to the Python language host [#15725](#15725) ### Bug Fixes - [auto] Tolerate missing stack and bookkeeping files in ProgramTest. [#15863](#15863) - [cli] Fix a panic when user's home directory could not be looked up [#15872](#15872) - [cli] Fix some commands that didn't respect `--disable-integrity-checking` [#15911](#15911) - [programgen/dotnet] Removes trailing whitespace from emitted DependsOn resource option expressions [#15892](#15892) - [auto/go] Avoid flakyness when reading the event log from pulumi commands [#15856](#15856) - [sdk/go] Fix Provider and Providers options in Go transform functions [#15885](#15885) - [sdk/nodejs] Handle serialization of aliases for well known native functions [#15873](#15873) - [sdk/nodejs] Correctly serialise functions whose code would make use of reserved identifiers [#15879](#15879) - [sdk/nodejs] Serialize function values obtained from Function.bind [#15887](#15887) - [sdk/python] Improve types of getters in Python SDK [#15865](#15865) - [sdkgen/{dotnet,go}] Fixes SDK-generation when referencing shared types in config variables [#15772](#15772) ### Miscellaneous - [sdk/nodejs] Update builtin module list for function serialization [#15830](#15830) - [sdk/nodejs] Set package.json engines to node >= 18 [#15845](#15845)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
Currently we reject all unknowns during `pulumi up`. However we are soon going to allow them to come through via `up --continue-on-error`, and thus should no longer error out when we have them. This is a similar preparatory PR to #15898, except that Go deals with the unknowns a little different, so we don't need to treat apply specially, but the marshalling.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
### Features
- [auto/{go,nodejs,python}] Add support for continue-on-error parameter
of the destroy command to the Automation API
[#15921](#15921)
- [cli] Support always fully qualifying stack names in CLI output
[#15857](#15857)
- [cli] Add --no-plugins and --no-dependencies to `pulumi install`
[#15910](#15910)
- [docs] Implement Java constructor syntax examples
[#15805](#15805)
- [sdk/nodejs] Make TypeScript and ts-node optional peer dependencies to
allow using user specified versions
[#15622](#15622)
- [sdk/{nodejs,python}] Allow apply to have unknown values during
updates
[#15898](#15898)
- [sdk/python] Add 'typeChecker' runtime option to the Python language
host
[#15922](#15922)
[#15725](#15725)
### Bug Fixes
- [auto] Tolerate missing stack and bookkeeping files in ProgramTest
[#15922](#15922)
[#15863](#15863)
- [cli] Fix a panic when user's home directory could not be looked up
[#15872](#15872)
- [cli] Fix some commands that didn't respect
`--disable-integrity-checking`
[#15911](#15911)
- [programgen/dotnet] Remove trailing whitespace from emitted DependsOn
resource option expressions
[#15922](#15922)
[#15892](#15892)
- [auto/go] Avoid flakyness when reading the event log from pulumi
commands
[#15856](#15856)
- [sdk/go] Fix Provider and Providers options in Go transform functions
[#15885](#15885)
- [sdk/nodejs] Handle serialization of aliases for well known native
functions
[#15873](#15873)
- [sdk/nodejs] Correctly serialise functions whose code would make use
of reserved identifiers
[#15879](#15879)
- [sdk/nodejs] Serialize function values obtained from Function.bind
[#15887](#15887)
- [sdk/python] Improve types of getters in Python SDK
[#15865](#15865)
- [sdkgen/{dotnet,go}] Fix SDK-generation when referencing shared types
in config variables
[#15772](#15772)
[#15922](#15922)
### Miscellaneous
- [sdk/nodejs] Update builtin module list for function serialization
[#15830](#15830)
- [sdk/nodejs] Set package.json engines to node >= 18
[#15845](#15845)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently during updates we try to make the values known during apply, even if they are marked unknown. This results in knows that should really still be unknown.
Note that this behaviour is currently encoded in tests, which also needed to change.