Add some missing checks for DisableIntegrityChecking #15911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/DisableIntegrityChecking
branch
from
d526cfe
to
6153449
Compare
Changelog[uncommitted] (2024-04-11)Bug Fixes
|
Frassle
commented
Apr 11, 2024
| cmdutil.Diag().Warningf(diag.Message("", msg)) | ||
| } else { | ||
| result = multierror.Append(result, errors.New(msg)) | ||
| if !backend.DisableIntegrityChecking { |
There was a problem hiding this comment.
Not actually sure if we should check DisableIntegrityChecking here given we've also already got the force option.
There was a problem hiding this comment.
I think we still should. It would be kind of confusing to have to remember to use a --force option here when --disable-integrity-checking doesn't work.
tgummerer
approved these changes
Apr 11, 2024
| cmdutil.Diag().Warningf(diag.Message("", msg)) | ||
| } else { | ||
| result = multierror.Append(result, errors.New(msg)) | ||
| if !backend.DisableIntegrityChecking { |
There was a problem hiding this comment.
I think we still should. It would be kind of confusing to have to remember to use a --force option here when --disable-integrity-checking doesn't work.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
### Features - [cli] Support always fully qualifying stack names in CLI output [#15857](#15857) - [cli] Add --no-plugins and --no-dependencies to `pulumi install` [#15910](#15910) - [docs] Implement Java constructor syntax examples [#15805](#15805) - [sdk/nodejs] Make TypeScript and ts-node optional peer dependencies to allow using user specified versions [#15622](#15622) - [sdk/{nodejs,python}] Allow apply to have unknown values during updates [#15898](#15898) - [sdk/python] Adds 'typeChecker' runtime option to the Python language host [#15725](#15725) ### Bug Fixes - [auto] Tolerate missing stack and bookkeeping files in ProgramTest. [#15863](#15863) - [cli] Fix a panic when user's home directory could not be looked up [#15872](#15872) - [cli] Fix some commands that didn't respect `--disable-integrity-checking` [#15911](#15911) - [programgen/dotnet] Removes trailing whitespace from emitted DependsOn resource option expressions [#15892](#15892) - [auto/go] Avoid flakyness when reading the event log from pulumi commands [#15856](#15856) - [sdk/go] Fix Provider and Providers options in Go transform functions [#15885](#15885) - [sdk/nodejs] Handle serialization of aliases for well known native functions [#15873](#15873) - [sdk/nodejs] Correctly serialise functions whose code would make use of reserved identifiers [#15879](#15879) - [sdk/nodejs] Serialize function values obtained from Function.bind [#15887](#15887) - [sdk/python] Improve types of getters in Python SDK [#15865](#15865) - [sdkgen/{dotnet,go}] Fixes SDK-generation when referencing shared types in config variables [#15772](#15772) ### Miscellaneous - [sdk/nodejs] Update builtin module list for function serialization [#15830](#15830) - [sdk/nodejs] Set package.json engines to node >= 18 [#15845](#15845)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
### Features
- [auto/{go,nodejs,python}] Add support for continue-on-error parameter
of the destroy command to the Automation API
[#15921](#15921)
- [cli] Support always fully qualifying stack names in CLI output
[#15857](#15857)
- [cli] Add --no-plugins and --no-dependencies to `pulumi install`
[#15910](#15910)
- [docs] Implement Java constructor syntax examples
[#15805](#15805)
- [sdk/nodejs] Make TypeScript and ts-node optional peer dependencies to
allow using user specified versions
[#15622](#15622)
- [sdk/{nodejs,python}] Allow apply to have unknown values during
updates
[#15898](#15898)
- [sdk/python] Add 'typeChecker' runtime option to the Python language
host
[#15922](#15922)
[#15725](#15725)
### Bug Fixes
- [auto] Tolerate missing stack and bookkeeping files in ProgramTest
[#15922](#15922)
[#15863](#15863)
- [cli] Fix a panic when user's home directory could not be looked up
[#15872](#15872)
- [cli] Fix some commands that didn't respect
`--disable-integrity-checking`
[#15911](#15911)
- [programgen/dotnet] Remove trailing whitespace from emitted DependsOn
resource option expressions
[#15922](#15922)
[#15892](#15892)
- [auto/go] Avoid flakyness when reading the event log from pulumi
commands
[#15856](#15856)
- [sdk/go] Fix Provider and Providers options in Go transform functions
[#15885](#15885)
- [sdk/nodejs] Handle serialization of aliases for well known native
functions
[#15873](#15873)
- [sdk/nodejs] Correctly serialise functions whose code would make use
of reserved identifiers
[#15879](#15879)
- [sdk/nodejs] Serialize function values obtained from Function.bind
[#15887](#15887)
- [sdk/python] Improve types of getters in Python SDK
[#15865](#15865)
- [sdkgen/{dotnet,go}] Fix SDK-generation when referencing shared types
in config variables
[#15772](#15772)
[#15922](#15922)
### Miscellaneous
- [sdk/nodejs] Update builtin module list for function serialization
[#15830](#15830)
- [sdk/nodejs] Set package.json engines to node >= 18
[#15845](#15845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This would have helped with #15831 as the
destroywould have been able to run instead of err'ing on the first save because of the already broken snapshot.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change