Fix race condition when listing stacks #15931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listing stacks, we currently try to get all the stacks from the backend, and then get the checkpoint to for each stack to show the summary. However there's a race between listing the stacks and getting the checkpoints, so the checkpoint may be missing by the time we get to that part of the code. Unfortunately the errors we're getting form getCheckpoint are not structured, so we can't tell if we got a 404 from the cloud here, so the next best option we have is re-checking whether the stack still exists.
Frassle
reviewed
Apr 15, 2024
pkg/backend/diy/backend.go
Outdated
| return nil, nil, err | ||
| // There is a race between listing stacks and getting their checkpoints. If there's an error getting | ||
| // the checkpoint, check if the stack still exists before returning an error. | ||
| stacks, stackErr := b.getStacks(ctx) |
There was a problem hiding this comment.
Use stackExists rather than listing the whole bucket again.
There was a problem hiding this comment.
Ah neat that's much better!
Changelog[uncommitted] (2024-04-15)Bug Fixes
|
Frassle
approved these changes
Apr 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing stacks, we currently try to get all the stacks from the backend, and then get the checkpoint to for each stack to show the summary.
However there's a race between listing the stacks and getting the checkpoints, so the checkpoint may be missing by the time we get to that part of the code.
Unfortunately the errors we're getting form getCheckpoint are not structured, so we can't tell if we got a 404 from the cloud here, so the next best option we have is re-checking whether the stack still exists.
This is another attempt at fixing #15658.