[snapshot] Elide writes for RRO with no changes #15976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes elide checkpoint writes for RegisterResourceOutputs steps if the associated resource's outputs have not changed. This can eliminate unnecessary snapshot writes for stacks with large numbers of component resources whose outputs do not change.
|
Working on tests tomorrow. |
Changelog[uncommitted] (2024-04-18)Features
|
|
This is ready to review. |
justinvp
approved these changes
Apr 18, 2024
Frassle
approved these changes
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merged
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sigh |
|
What a farce |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
To be merged after #15976.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes elide checkpoint writes for RegisterResourceOutputs steps if the associated resource's outputs have not changed. This can eliminate unnecessary snapshot writes for stacks with large numbers of component resources whose outputs do not change.