Test setting and changing providers on component resources via transforms #16022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-23)Bug Fixes
|
Frassle
force-pushed
the
fraser/fixCollapse
branch
2 times, most recently
from
8b53872
to
fa75c44
Compare
Frassle
commented
Apr 22, 2024
| @@ -318,7 +319,12 @@ def __init__(self, props: "Inputs", opts: "ResourceOptions") -> None: | |||
| self.opts = opts | |||
|
|
|||
|
|
|||
| ResourceTransform = Callable[[ResourceTransformArgs], Optional[ResourceTransformResult]] | |||
| ResourceTransform = Callable[ | |||
There was a problem hiding this comment.
Made this optionally async like the NodeJS version.
tgummerer
approved these changes
Apr 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Frassle
force-pushed
the
fraser/fixCollapse
branch
from
b813e6c
to
b7c75f6
Compare
Frassle
force-pushed
the
fraser/fixCollapse
branch
from
b7c75f6
to
7a757b3
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Tentative changelog, but also planning to include #16057 ### Features - [auto/{go,nodejs,python}] Add support for the continue-on-error parameter of the up command to the Automation API [#15953](#15953) - [engine] Add a --continue-on-error flag to pulumi up [#15740](#15740) ### Bug Fixes - [sdk/nodejs] Fix a race condition that could cause the NodeJS runtime to terminate before finishing all work [#16005](#16005) - [sdk/python] Fix an exception when setting providers resource option with a dict [#16022](#16022) - [sdk/python] Fix event loop tracking in the python SDK when using remote transforms [#16039](#16039) - [sdk/python] Workaround lazy module loading regression [#16038](#16038) ### Miscellaneous - [cli/plugin] Move PluginKind type definition into apitype and re-export for backward compatibility
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Will wait to merge this until after #16057 merges ### Features - [auto/{go,nodejs,python}] Add support for the continue-on-error parameter of the up command to the Automation API [#15953](#15953) - [engine] Add a --continue-on-error flag to pulumi up [#15740](#15740) ### Bug Fixes - [sdk/nodejs] Fix a race condition that could cause the NodeJS runtime to terminate before finishing all work [#16005](#16005) - [sdk/python] Fix an exception when setting providers resource option with a dict [#16022](#16022) - [sdk/python] Fix event loop tracking in the python SDK when using remote transforms [#16039](#16039) - [sdk/python] Workaround lazy module loading regression [#16038](#16038) ### Miscellaneous - [cli/plugin] Move PluginKind type definition into apitype and re-export for backward compatibility [#15946](#15946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15984.
The bug was actually caused by a longstanding mistake in
_collapse_providersthat didn't iterate the providers correctly if it was passed as adict. But worth having this test in full to sanity check the other languages as well.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change