-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk/python] Workaround lazy module regression #16038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-23)Bug Fixes
|
justinvp
force-pushed
the
justin/pylazyload
branch
2 times, most recently
from
April 23, 2024 07:42
7f31ca6
to
4cd0d68
Compare
Frassle
approved these changes
Apr 23, 2024
A regression was introduced in Python 3.11.9 and 3.12.3 that breaks lazy loaded `config` modules in generated Pulumi provider Python SDKs. It's unclear if this is going to be addressed in subsequent patch releases of Python, so we workaround the problem by using a copy of the Python stdlib's `_LazyModule` and `LazyLoader` classes that don't have the regression, as suggested by the Python maintainers.
justinvp
force-pushed
the
justin/pylazyload
branch
from
April 23, 2024 16:13
4cd0d68
to
4d1b05b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Tentative changelog, but also planning to include #16057 ### Features - [auto/{go,nodejs,python}] Add support for the continue-on-error parameter of the up command to the Automation API [#15953](#15953) - [engine] Add a --continue-on-error flag to pulumi up [#15740](#15740) ### Bug Fixes - [sdk/nodejs] Fix a race condition that could cause the NodeJS runtime to terminate before finishing all work [#16005](#16005) - [sdk/python] Fix an exception when setting providers resource option with a dict [#16022](#16022) - [sdk/python] Fix event loop tracking in the python SDK when using remote transforms [#16039](#16039) - [sdk/python] Workaround lazy module loading regression [#16038](#16038) ### Miscellaneous - [cli/plugin] Move PluginKind type definition into apitype and re-export for backward compatibility
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Will wait to merge this until after #16057 merges ### Features - [auto/{go,nodejs,python}] Add support for the continue-on-error parameter of the up command to the Automation API [#15953](#15953) - [engine] Add a --continue-on-error flag to pulumi up [#15740](#15740) ### Bug Fixes - [sdk/nodejs] Fix a race condition that could cause the NodeJS runtime to terminate before finishing all work [#16005](#16005) - [sdk/python] Fix an exception when setting providers resource option with a dict [#16022](#16022) - [sdk/python] Fix event loop tracking in the python SDK when using remote transforms [#16039](#16039) - [sdk/python] Workaround lazy module loading regression [#16038](#16038) ### Miscellaneous - [cli/plugin] Move PluginKind type definition into apitype and re-export for backward compatibility [#15946](#15946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in Python 3.11.9 and 3.12.3 that breaks lazy loaded
config
modules in generated Pulumi provider Python SDKs. It's unclear if this is going to be addressed in subsequent patch releases of Python, so we workaround the problem by using a copy of the Python stdlib's_LazyModule
andLazyLoader
classes that don't have the regression, as suggested by the Python maintainers.Fixes #15882