Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a fresh context for automation api runs #16063

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Apr 26, 2024

Description

Looks like this should help with some async context tracking for python. We make a fresh context for running the Automation API program and so don't need to reset globals on exit.

We also fix configure to set the context variables rather than overwriting the SETTINGS object itself which is just a plain global.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@Frassle Frassle added the ci/test Test CI pipelines on this PR label Apr 26, 2024
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Apr 26, 2024

Changelog

[uncommitted] (2024-04-26)

Bug Fixes

  • [auto/python] Ensure async context is not shared between multiple programs
    #16063

@Frassle Frassle marked this pull request as ready for review April 26, 2024 07:53
@Frassle Frassle requested a review from a team as a code owner April 26, 2024 07:53
@Frassle Frassle enabled auto-merge April 26, 2024 08:03
@Frassle Frassle added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit 6bc7c4b Apr 26, 2024
92 checks passed
@Frassle Frassle deleted the fraser/contextvars branch April 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/test Test CI pipelines on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants