-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for --import-file when using the Automation API #16071
Conversation
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Changelog[uncommitted] (2024-04-29)Features
|
/run-acceptance-tests |
/run-acceptance-tests |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this looks like a good addition to the automation API.
Having a look at the code, I think this needs to be a string, to be able to pass an actual path argument to the CLI, I don't think this is just a binary flag.
Ah, good point! The output of the help command is quite confusing as it says I'll also update that as part of this PR unless you want me to raise a separate PR, also happy to do that. |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
faf127b
to
22b8cc1
Compare
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
/run-acceptance-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Agreed on the docstring, it's nice to update that so the help output is less confusing. I'm fine with keeping that in the same PR, just left a minor suggestion on formatting there.
Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
/run-acceptance-tests |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
/run-acceptance-tests |
@charlie-haley I saw CI was still failing and had a quick look. It looks like there was an |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Thanks! There was also an indentation problem in the stack.ts, it should hopefully all be green now |
/run-acceptance-tests |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
/run-acceptance-tests |
Thanks again for this contribution @charlie-haley! This is gonna go into the next pulumi release, which might happen this week (or potentially next, since we have a company offsite this week) |
Description
Fixes # (issue)
Checklist
make tidy
to update any new dependenciesmake lint
to verify my code passes the lint checkgofumpt
make changelog
and committed thechangelog/pending/<file>
documenting my change