Lock access when writing event timings in display #16101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-03)Bug Fixes
|
tgummerer
reviewed
May 2, 2024
lunaris
force-pushed
the
wjones/pulumi-16085
branch
from
c42a60a
to
2a9ec6d
Compare
tgummerer
approved these changes
May 3, 2024
This should fix #16085, in which we are getting concurrent reads and writes to the `opStopwatch` maps.
lunaris
force-pushed
the
wjones/pulumi-16085
branch
from
2a9ec6d
to
d698c59
Compare
Frassle
approved these changes
May 3, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
To be merged after #16119 merges. Tentative changelog: - [backend] Fix concurrent reads from and writes to display resource timer maps [#16101](#16101) - [engine] Better handle property dependencies and deleted-with relationships when pruning URNs, verifying snapshot integrity and computing dependency graphs. [#16088](#16088) - [programgen/python] Sort generated requirements.txt files when generating Python programs [#16115](#16115)
tgummerer
added a commit
that referenced
this pull request
May 6, 2024
The `m` mutex deadlocks in the display code. Split it up into an event mutex that works as it did before #16101, and add a separate mutex for the stopwatch, to avoid any deadlocks here.
tgummerer
added a commit
that referenced
this pull request
May 6, 2024
The `m` mutex deadlocks in the display code. Split it up into an event mutex that works as it did before #16101, and add a separate mutex for the stopwatch, to avoid any deadlocks here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #16085, in which we are getting concurrent reads and writes to the
opStopwatchmaps.