Updating python dynamic provider types for inputs to Dict[str, Any] #16102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-02)Features
|
tgummerer
reviewed
May 2, 2024
There was a problem hiding this comment.
What's the transition plan here? Will just adding this give users any additional warnings? If not, would we be better off just making the transition straight to typing this as Dict[str, Any], since users won't see any warnings with this change, so they wouldn't necessarily make any updates?
changelog/pending/20240502--sdk--updating-python-dynamic-provider-types.yaml
Outdated
Show resolved
Hide resolved
changelog/pending/20240502--sdk--updating-python-dynamic-provider-types.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
Frassle
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating python dynamic provider types for inputs to Dict[str, Any], from Any. I also added a Union so it was backward compatible, and doesn't immediately throw type errors for users.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change