Sort requirements.txt files when generating Python code
#16115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-03)Bug Fixes
|
tgummerer
approved these changes
May 3, 2024
Frassle
approved these changes
May 3, 2024
|
Also a small update to the PR description to add that it fixes the bug Thomas raised about the tests being flaky. |
lunaris
force-pushed
the
wjones/py-stable-reqs
branch
2 times, most recently
from
2c1bc2c
to
286d76d
Compare
Frassle
approved these changes
May 3, 2024
lunaris
force-pushed
the
wjones/py-stable-reqs
branch
from
286d76d
to
92fbbb7
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
To be merged after #16119 merges. Tentative changelog: - [backend] Fix concurrent reads from and writes to display resource timer maps [#16101](#16101) - [engine] Better handle property dependencies and deleted-with relationships when pruning URNs, verifying snapshot integrity and computing dependency graphs. [#16088](#16088) - [programgen/python] Sort generated requirements.txt files when generating Python programs [#16115](#16115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of our tests now generate multi-line
requirements.txtwhose order is dependent on that in which we enumerate packages when testing. This PR changes this so that we always sort them, meaning we can consistently check against snapshotted results (as opposed to having flaky tests that only pass when the generated order matches the one we happened to snapshot last).Fixes #16113