-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a race condition in python output handling #16155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-09)Bug Fixes
|
justinvp
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As we talked about, there's no obvious straightforward way to add a test for this.
tgummerer
approved these changes
May 9, 2024
changelog/pending/20240509--sdk-python--fix-a-race-condition-in-output-handling.yaml
Outdated
Show resolved
Hide resolved
…n-output-handling.yaml Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
Thank you |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 10, 2024
Tentative changelog: ### Bug Fixes - [engine] Fix dataraces between snapshot and deployment systems. [#16148](#16148) - [cli/display] Fix mangled diffs of strings containing url-encoded chars [#16147](#16147) - [sdk/nodejs] Don't load punycode module in function serialization code [#16149](#16149) - [sdk/python] Fix typings for `from_input` and `all` to not return `Never` types. [#16139](#16139) - [sdk/python] Fix a race condition in output handling [#16155](#16155)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
Tentative changelog: ### Bug Fixes - [engine] Fix dataraces between snapshot and deployment systems. [#16148](#16148) - [cli/display] Fix mangled diffs of strings containing url-encoded chars [#16147](#16147) - [sdk/nodejs] Don't load punycode module in function serialization code [#16149](#16149) - [sdk/nodejs] Return error in RPC response instead of exiting in the language runtime [#16162](#16162) - [sdk/nodejs] Return the underlying error if we can't locate the pulumi SDK [#16160](#16160) - [sdk/python] Provide more descriptive exception [#16098](#16098) - [sdk/python] Fix typings for `from_input` and `all` to not return `Never` types. [#16139](#16139) - [sdk/python] Fix a race condition in output handling [#16155](#16155) ### Miscellaneous - [pkg] Upgrade pulumi-java to v0.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16154.
Checklist
make tidy
to update any new dependenciesmake lint
to verify my code passes the lint checkgofumpt
make changelog
and committed thechangelog/pending/<file>
documenting my change