Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a race condition in python output handling #16155

Merged
merged 2 commits into from
May 9, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented May 9, 2024

Description

Fixes #16154.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@Frassle Frassle marked this pull request as ready for review May 9, 2024 15:59
@Frassle Frassle requested a review from a team as a code owner May 9, 2024 15:59
@pulumi-bot
Copy link
Contributor

pulumi-bot commented May 9, 2024

Changelog

[uncommitted] (2024-05-09)

Bug Fixes

  • [sdk/python] Fix a race condition in output handling
    #16155

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As we talked about, there's no obvious straightforward way to add a test for this.

…n-output-handling.yaml

Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
@Frassle Frassle enabled auto-merge May 9, 2024 16:13
@Frassle Frassle added this pull request to the merge queue May 9, 2024
Merged via the queue into master with commit 0f191ee May 9, 2024
49 checks passed
@Frassle Frassle deleted the fraser/pythonOutputError branch May 9, 2024 17:40
@MJLongstreth-tiq
Copy link

Thank you

github-merge-queue bot pushed a commit that referenced this pull request May 10, 2024
Tentative changelog:

### Bug Fixes

- [engine] Fix dataraces between snapshot and deployment systems.
  [#16148](#16148)

- [cli/display] Fix mangled diffs of strings containing url-encoded
chars
  [#16147](#16147)

- [sdk/nodejs] Don't load punycode module in function serialization code
  [#16149](#16149)

- [sdk/python] Fix typings for `from_input` and `all` to not return
`Never` types.
  [#16139](#16139)

- [sdk/python] Fix a race condition in output handling
  [#16155](#16155)
@justinvp justinvp mentioned this pull request May 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
Tentative changelog:

### Bug Fixes

- [engine] Fix dataraces between snapshot and deployment systems.
  [#16148](#16148)

- [cli/display] Fix mangled diffs of strings containing url-encoded
chars
  [#16147](#16147)

- [sdk/nodejs] Don't load punycode module in function serialization code
  [#16149](#16149)

- [sdk/nodejs] Return error in RPC response instead of exiting in the
language runtime
  [#16162](#16162)

- [sdk/nodejs] Return the underlying error if we can't locate the pulumi
SDK
  [#16160](#16160)

- [sdk/python] Provide more descriptive exception
  [#16098](#16098)

- [sdk/python] Fix typings for `from_input` and `all` to not return
`Never` types.
  [#16139](#16139)

- [sdk/python] Fix a race condition in output handling
  [#16155](#16155)


### Miscellaneous

- [pkg] Upgrade pulumi-java to v0.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants