Return error in RPC response instead of exiting in the language runtime #16162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-10)Bug Fixes
|
lunaris
approved these changes
May 10, 2024
julienp
force-pushed
the
julienp/rpc-error
branch
from
b574722
to
2776a0c
Compare
Base automatically changed from
julienp/ambiguous-error-when-package.json-error
to
master
May 10, 2024 14:31
If we can't start the node process for some reason, report back the error via RPC instead of exiting immediately.
julienp
force-pushed
the
julienp/rpc-error
branch
from
2776a0c
to
fa378e7
Compare
Frassle
approved these changes
May 10, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
Tentative changelog: ### Bug Fixes - [engine] Fix dataraces between snapshot and deployment systems. [#16148](#16148) - [cli/display] Fix mangled diffs of strings containing url-encoded chars [#16147](#16147) - [sdk/nodejs] Don't load punycode module in function serialization code [#16149](#16149) - [sdk/nodejs] Return error in RPC response instead of exiting in the language runtime [#16162](#16162) - [sdk/nodejs] Return the underlying error if we can't locate the pulumi SDK [#16160](#16160) - [sdk/python] Provide more descriptive exception [#16098](#16098) - [sdk/python] Fix typings for `from_input` and `all` to not return `Never` types. [#16139](#16139) - [sdk/python] Fix a race condition in output handling [#16155](#16155) ### Miscellaneous - [pkg] Upgrade pulumi-java to v0.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we can't start the node process for some reason, report back the error via RPC instead of exiting immediately.
Fixes #11706
Instead of:
we get
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change