fix a panic when refresh is used with --continue-on-error #16184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refreshes have their own way of dealing with errors, which does not match what we want to do with ContinueOnError (it's further reaching, we still want to refresh dependents of failed resources). Therefore we made them mutually exclusive. The original change however missed that it's also possible for refreshes to happen during `pulumi up` using the `--refresh` flag. This currently results in an assert/panic. Fix this by not passing the `ContinueOnError` option through when we have a refresh. This still gives us the right behaviour since refresh ignores the errors anyway.
Changelog[uncommitted] (2024-05-13)Bug Fixes
|
Frassle
approved these changes
May 13, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
### Features - [docs] Resource docs: bump the number of displayed supporting types from 200 to 1000 by default [#16185](#16185) - [sdk/go] Prefer pluginDownloadURLOverrides over PluginDownloadURL specified in the package [#16186](#16186) ### Bug Fixes - [engine] Fix panic when using `pulumi up --refresh --continue-on-error` [#16184](#16184)
This was referenced Jun 5, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshes have their own way of dealing with errors, which does not match what we want to do with ContinueOnError (it's further reaching, we still want to refresh dependents of failed resources). Therefore we made them mutually exclusive.
The original change however missed that it's also possible for refreshes to happen during
pulumi upusing the--refreshflag. This currently results in an assert/panic.Fix this by not passing the
ContinueOnErroroption through when we have a refresh. This still gives us the right behaviour since refresh ignores the errors anyway.Fixes #16177
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change