Prefer pluginDownloadURLOverrides over PluginDownloadURL specified in the package #16186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-13)Features
|
tgummerer
approved these changes
May 13, 2024
Frassle
approved these changes
May 13, 2024
mikhailshilkov
deleted the
mikhailshilkov/prefer-plugin-downloadurl-override
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
### Features - [docs] Resource docs: bump the number of displayed supporting types from 200 to 1000 by default [#16185](#16185) - [sdk/go] Prefer pluginDownloadURLOverrides over PluginDownloadURL specified in the package [#16186](#16186) ### Bug Fixes - [engine] Fix panic when using `pulumi up --refresh --continue-on-error` [#16184](#16184)
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overriding plugin download URLs with compilation flags was originally added in #8798. Its intent was allowing our customers to override download locations for all plugins, so that only trusted pre-approved plugins could be downloaded.
Since then, we've added
PluginDownloadURLfor a package, which is the default URL for that package's binary if it's shipped outside our Pulumi org. Currently,PluginDownloadURLtakes precedence overpluginDownloadURLOverrides, which means it's impossible to override third-party package binary locations.This PR changes plugin source resolution to flip the priority of those two. If an override matches regex, its URL will take priority over the default
PluginDownloadURLspecified in the package.I have added tests to verify
pluginDownloadURLOverrideswith and withoutPluginDownloadURL. The second one fails before my change.Resolves #16058
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change