Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load snapshot just to show stack name #9199

Merged
merged 3 commits into from Mar 15, 2022
Merged

Don't load snapshot just to show stack name #9199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f09445
Don't load snapshot just to show stack name
Frassle Mar 15, 2022
3f3b0fe
Add to CHANGELOG
Frassle Mar 15, 2022
7c09cc2
Merge branch 'master' into fraser/showStackName
Frassle Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG_PENDING.md
View file
Open in desktop
Expand Up @@ -4,11 +4,14 @@
- [language/dotnet] - Updated Pulumi dotnet packages to use grpc-dotnet instead of grpc.
[#9149](https://github.com/pulumi/pulumi/pull/9149)

- [cli/config] Rename the `config` property in `Pulumi.yaml` to `stackConfigDir`. The `config` key will continue to be supported.
- [cli/config] - Rename the `config` property in `Pulumi.yaml` to `stackConfigDir`. The `config` key will continue to be supported.
[#9145](https://github.com/pulumi/pulumi/pull/9145)

- [cli/plugins] Add support for downloading plugin from private Pulumi GitHub releases. This also drops the use of the `GITHUB_ACTOR` and `GITHUB_PERSONAL_ACCESS_TOKEN` environment variables for authenticating to github. Only `GITHUB_TOKEN` is now used, but this can be set to a personal access token.
[#9185](https://github.com/pulumi/pulumi/pull/9185)

- [cli] - Speed up `pulumi stack --show-name` by skipping unneeded snapshot loading.
[#9199](https://github.com/pulumi/pulumi/pull/9199)

### Bug Fixes

Expand Down
9 changes: 5 additions & 4 deletions pkg/cmd/pulumi/stack.go
View file
Open in desktop
Expand Up @@ -56,16 +56,17 @@ func newStackCmd() *cobra.Command {
if err != nil {
return err
}
snap, err := s.Snapshot(commandContext())
if err != nil {
return err
}

if showStackName {
fmt.Printf("%s\n", s.Ref().Name())
return nil
}

snap, err := s.Snapshot(commandContext())
if err != nil {
return err
}

// First print general info about the current stack.
fmt.Printf("Current stack is %s:\n", s.Ref())

Expand Down