Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read needs a non-empty ID #9243

Merged
merged 7 commits into from Mar 18, 2022
Merged

Read needs a non-empty ID #9243

merged 7 commits into from Mar 18, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Mar 18, 2022

Description

I'm getting an internal assertion thrown here: https://github.com/pulumi/pulumi/blob/8b516bb05434ca8c6dac94b76a5583e855ffd0b6/sdk/go/common/resource/plugin/provider_plugin.go#L808
(Actually, it's line 807 in the stack trace, but presumably either the URN or ID is empty..)
This is in a brand new project/stack. Never been deployed. Any ideas on what I should be looking for? (edited) 

This was due to accidentally passing "" as the ID in a get call. This PR fixes it so we now report an error like Expected an ID for urn:pulumi:test::test::pkgA:m:typA::resA rather than a panic due to an assert.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle requested review from iwahbe and t0yv0 and removed request for iwahbe March 18, 2022 10:16
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving error messages is always great. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants