Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check update plans against invalid resources #9254

Merged
merged 2 commits into from Mar 21, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Mar 21, 2022

Description

If Check returns failures it won't return any new inputs that we can check plans against. The resource will failed anyway because of the check failure so we can just skip checking against the update plan.

Fixes #9247

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Frassle Frassle merged commit 272511a into master Mar 21, 2022
@pulumi-bot pulumi-bot deleted the fraser/checkfailuresplans branch March 21, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental Update plans fails with "panic: fatal: An assertion has failed" when using StackReference
2 participants