Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "pulumi state clear-pending-operations" #9270

Closed
wants to merge 2 commits into from

Conversation

Zaid-Ajaj
Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj commented Mar 22, 2022

Description

This PR implements pulumi state clear-pending-operations as an easier to way to clear pending operations from checkpoint files instead of exporting, editing and importing the stack files.

Fixes #4265. In that issue it is also discussed whether or not pulumi should internally and automatically decide to clear the pending operations. I am personally not sure either about the solution but for the time being at least the users will be able to easily clear the operations themselves without having to edit JSON files by hand.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Zaid-Ajaj Zaid-Ajaj requested a review from Frassle March 22, 2022 20:12
@lukehoban
Copy link
Member

My thinking was that we would address this via the approach outlined in #4265 (comment). Any reason to prefer this approach over that? It seems that the approach noted there takes a lot more of the friction away from users proactively.

@Zaid-Ajaj
Copy link
Contributor Author

Zaid-Ajaj commented Mar 22, 2022

Any reason to prefer this approach over that?

@lukehoban I liked that approach personally but didn't realise it was the consensus as the final solution so I fell back to what the users initially asked for. Also just found out that [engine] Clear pending operations with refresh. partially addresses this issue but it has been open for a while.

I am thinking the following:

@lukehoban
Copy link
Member

I am thinking the following:

Perfect - sounds like a good plan!

@Zaid-Ajaj
Copy link
Contributor Author

Closing in favor of #9293

@Zaid-Ajaj Zaid-Ajaj closed this Mar 25, 2022
@Zaid-Ajaj Zaid-Ajaj deleted the clear-pending-operations branch March 25, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier way to remove/clear pending operations
2 participants