Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape deprecation messages before interpolating into source text #9371

Merged
merged 4 commits into from Apr 8, 2022
Merged

Escape deprecation messages before interpolating into source text #9371

merged 4 commits into from Apr 8, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Apr 8, 2022 •
edited

Description

Fixes #9342

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-random with merge commit ee0e97d

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azuread with merge commit ee0e97d

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-kubernetes with merge commit ee0e97d

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-gcp with merge commit ee0e97d

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure with merge commit ee0e97d

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-aws with merge commit ee0e97d

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-random with merge commit 7fc80f3

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azuread with merge commit 7fc80f3

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-kubernetes with merge commit 7fc80f3

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-gcp with merge commit 7fc80f3

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure with merge commit 7fc80f3

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-aws with merge commit 7fc80f3

iwahbe
iwahbe approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have a question and a nit, but otherwise LGTM.

Nit: since this is a general function, I think we should put it in nodejs/utilities.go instead of nodejs/gen.go. Feel free to ignore this.

Are there any other strings we generate that should be escaped? Comments are /* */ style, so it's not a problem there. I don't think we escape constant values, but we probably should.

danielrbradley
danielrbradley approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thank you!

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure-native with merge commit ee0e97d

@Frassle
Copy link
Member Author

Frassle commented Apr 8, 2022

Are there any other strings we generate that should be escaped?

It looks like other strings are using module/type/property names which should already be string safe.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azuread with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-random with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-kubernetes with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-gcp with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-random with merge commit 66b13bd

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azuread with merge commit 66b13bd

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-kubernetes with merge commit 66b13bd

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-aws with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-gcp with merge commit 66b13bd

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure with merge commit 66b13bd

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-aws with merge commit 66b13bd

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure-native with merge commit 7fc80f3

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure-native with merge commit 1fca65f

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Diff for pulumi-azure-native with merge commit 66b13bd

@Frassle Frassle merged commit 7a25733 into master Apr 8, 2022
@pulumi-bot pulumi-bot deleted the fraser/fixjsstring branch April 8, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrbradley danielrbradley danielrbradley approved these changes

@iwahbe iwahbe iwahbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript deprecation message not escaped
3 participants
@Frassle @danielrbradley @iwahbe