Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin java template maven dependency to latest known good version. #530

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

dixler
Copy link
Contributor

@dixler dixler commented Mar 3, 2023

This commit pins org.apache.maven.plugins:maven-compiler-plugin to 3.5.1 to resolve failing builds for UBI images on pulumi-docker-containers.

pulumi/pulumi-docker-containers#127

Context

pulumi-docker-containers has 2 different java builds.

  • Debian (passing)
  • UBI (failing)

UBI is failing running a test that runs the java pulumi/template with the following error message:

Error: umi:pulumi:Stack test-env4268922448-p-it-ea7a4b0c6d-test-env42-4bd12ab9 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project test-env4268922448: Fatal error compiling: error: release version 11 not supported -> [Help 1]

The Debian and UBI images differ on the version of org.apache.maven.plugins:maven-compiler-plugin

When running locally on the image with the modified pom.xml the build succeeds on 3.5.1, but the tested versions including 3.6.0 and latest (3.11.0 as of writing) provided the following error as of writing when running pulumi pre inside the UBI docker image:

Diagnostics:
  pulumi:pulumi:Stack (jawwa-dev):
    [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project jawwa: Fatal error compiling: error: release version 11 not supported -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

    error: an unhandled error occurred: '/root/.sdkman/candidates/maven/current/bin/mvn /root/.sdkman/candidates/maven/current/bin/mvn -Dorg.slf4j.simpleLogger.defaultLogLevel=warn --no-transfer-progress compile exec:java' exited with non-zero exit code: 1

…5.1.

to resolve failing builds for UBI images on pulumi-docker-containers.

 pulumi/pulumi-docker-containers#127
@dixler dixler requested a review from a team March 3, 2023 21:52
@dixler dixler marked this pull request as ready for review March 3, 2023 21:54
@dixler dixler merged commit 0069fe0 into master Mar 6, 2023
@dixler dixler deleted the dixler/fix-docker-container-test branch March 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants