-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DSL hook processing logic to be consistent #3376
base: master
Are you sure you want to change the base?
Conversation
@@ -731,6 +729,8 @@ def on_booted(&block) | |||
# @version 5.0.0 | |||
# | |||
def on_refork(key = nil, &block) | |||
warn_if_in_single_mode('on_refork') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense here? This seemed to be the only cluster mode related hook that was missing the warning.
"so your `#{hook_name}` block did not run" | ||
"so your `#{hook_name}` block will not run." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warning is displayed during configuration, so it makes more sense to tell the user that it will not run, as the hooks haven't actually been processed yet.
6692b90
to
7c6c31e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added coverage for hooks missing in this suite.
Note to self, related PR: #3380. |
Description
Noticed some inconsistencies with how the DSL processes hooks while working on #3375, this was also opened as a split up prerequisite for #3377.
Ensures all hook DSL methods utilise
#process_hooks
+ some minor changes (see comments).Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.