Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bot user agent to non-scrolled page #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juanmardefago
Copy link

While trying this script with both LazySizes and LazyLoad libraries, I found out that the tests would always fail. It seems that the bot user agent wasn't specified, either unintentionally or not, but it caused much confusion.

Lazyload uses the IntersectionObserver API, so the test failing cause lots of confusion about why was this happening.

Here's the issue where this was being discussed: verlok/vanilla-lazyload#277

This is the main repo for both libraries:

To clarify, I've run the script on a project i'm working on, which had two different implementations of lazyloading on different branches, one with lazysizes, another one with lazyload, and both failed, even though they are actually implemented in a way that should be compliant according to the docs (https://developers.google.com/search/docs/guides/lazy-loading).

Hope this helps.

Also, if the exclusion of the UA is intentional, It would be good to have an explanation. Someone actually asked this some time ago, but received no answer (#27).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@juanmardefago
Copy link
Author

@googlebot rescan

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants