Skip to content

Commit

Permalink
chore: add TODO to use size parameter in getReadableFromProtocolStream (
Browse files Browse the repository at this point in the history
  • Loading branch information
OrKoN committed Jan 28, 2022
1 parent 776ced6 commit 000c1f6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/common/helper.ts
Expand Up @@ -357,6 +357,9 @@ async function getReadableFromProtocolStream(
let eof = false;
return new Readable({
async read() {
// TODO: use the advised size parameter to read function once
// crbug.com/1290727 is resolved.
// Also, see https://github.com/puppeteer/puppeteer/pull/7868.
if (eof) {
return null;
}
Expand Down

0 comments on commit 000c1f6

Please sign in to comment.