chore(docs): migrate Connection + CDP event defs (#6180)

puppeteer · Jul 8, 2020 · 0e93880 · 0e93880
1 parent 74cb2ce
commit 0e93880
Show file tree

Hide file tree

Showing 23 changed files with 29 additions and 336 deletions.
diff --git a/new-docs/puppeteer.connection._callbacks.md b/new-docs/puppeteer.connection._callbacks.md
diff --git a/new-docs/puppeteer.connection._closed.md b/new-docs/puppeteer.connection._closed.md
diff --git a/new-docs/puppeteer.connection._constructor_.md b/new-docs/puppeteer.connection._constructor_.md
diff --git a/new-docs/puppeteer.connection._delay.md b/new-docs/puppeteer.connection._delay.md
diff --git a/new-docs/puppeteer.connection._lastid.md b/new-docs/puppeteer.connection._lastid.md
diff --git a/new-docs/puppeteer.connection._onclose.md b/new-docs/puppeteer.connection._onclose.md
diff --git a/new-docs/puppeteer.connection._onmessage.md b/new-docs/puppeteer.connection._onmessage.md
diff --git a/new-docs/puppeteer.connection._rawsend.md b/new-docs/puppeteer.connection._rawsend.md
diff --git a/new-docs/puppeteer.connection._sessions.md b/new-docs/puppeteer.connection._sessions.md
diff --git a/new-docs/puppeteer.connection._transport.md b/new-docs/puppeteer.connection._transport.md
diff --git a/new-docs/puppeteer.connection._url.md b/new-docs/puppeteer.connection._url.md
diff --git a/new-docs/puppeteer.connection.createsession.md b/new-docs/puppeteer.connection.createsession.md
diff --git a/new-docs/puppeteer.connection.dispose.md b/new-docs/puppeteer.connection.dispose.md
diff --git a/new-docs/puppeteer.connection.fromsession.md b/new-docs/puppeteer.connection.fromsession.md
diff --git a/new-docs/puppeteer.connection.md b/new-docs/puppeteer.connection.md
diff --git a/new-docs/puppeteer.connection.send.md b/new-docs/puppeteer.connection.send.md
diff --git a/new-docs/puppeteer.connection.session.md b/new-docs/puppeteer.connection.session.md
diff --git a/new-docs/puppeteer.connection.url.md b/new-docs/puppeteer.connection.url.md
diff --git a/new-docs/puppeteer.md b/new-docs/puppeteer.md
@@ -13,7 +13,6 @@
 |  [BrowserContext](./puppeteer.browsercontext.md) | BrowserContexts provide a way to operate multiple independent browser sessions. When a browser is launched, it has a single BrowserContext used by default. The method [Browser.newPage](./puppeteer.browser.newpage.md) creates a page in the default browser context. |
 |  [BrowserFetcher](./puppeteer.browserfetcher.md) | BrowserFetcher can download and manage different versions of Chromium and Firefox. |
 |  [CDPSession](./puppeteer.cdpsession.md) | The <code>CDPSession</code> instances are used to talk raw Chrome Devtools Protocol. |
-|  [Connection](./puppeteer.connection.md) |  |
 |  [ConsoleMessage](./puppeteer.consolemessage.md) | ConsoleMessage objects are dispatched by page via the 'console' event. |
 |  [Coverage](./puppeteer.coverage.md) | The Coverage class provides methods to gathers information about parts of JavaScript and CSS that were used by the page. |
 |  [Dialog](./puppeteer.dialog.md) | Dialog instances are dispatched by the [Page](./puppeteer.page.md) via the <code>dialog</code> event. |

diff --git a/src/common/Browser.ts b/src/common/Browser.ts
@@ -18,9 +18,8 @@ import { assert } from './assert';
 import { helper } from './helper';
 import { Target } from './Target';
 import { EventEmitter } from './EventEmitter';
-import { Events } from './Events';
 import Protocol from '../protocol';
-import { Connection } from './Connection';
+import { Connection, ConnectionEmittedEvents } from './Connection';
 import { Page } from './Page';
 import { ChildProcess } from 'child_process';
 import { Viewport } from './PuppeteerViewport';
@@ -194,7 +193,7 @@ export class Browser extends EventEmitter {
       );
 
     this._targets = new Map();
-    this._connection.on(Events.Connection.Disconnected, () =>
+    this._connection.on(ConnectionEmittedEvents.Disconnected, () =>
       this.emit(BrowserEmittedEvents.Disconnected)
     );
     this._connection.on('Target.targetCreated', this._targetCreated.bind(this));