chore: strict-mode TS for DOMWorld (#8398)

puppeteer · May 25, 2022 · 256223a · 256223a
1 parent f866274
commit 256223a
Show file tree

Hide file tree

Showing 3 changed files with 121 additions and 53 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -126,7 +126,10 @@ module.exports = {
       ],
       rules: {
         'no-unused-vars': 0,
-        '@typescript-eslint/no-unused-vars': 2,
+        '@typescript-eslint/no-unused-vars': [
+          'error',
+          { argsIgnorePattern: '^_' },
+        ],
         'func-call-spacing': 0,
         '@typescript-eslint/func-call-spacing': 2,
         semi: 0,
@@ -140,6 +143,8 @@ module.exports = {
         '@typescript-eslint/explicit-function-return-type': 0,
         // We know it's bad and use it very sparingly but it's needed :(
         '@typescript-eslint/ban-ts-ignore': 0,
+        // We allow non-null assertions if the value was asserted using `assert` API.
+        '@typescript-eslint/no-non-null-assertion': 0,
         /**
          * This is the default options (as per
          * https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/docs/rules/ban-types.md),