fix: Page.waitForDevicePrompt crash (#11153)

puppeteer · Oct 15, 2023 · 257be15 · 257be15
1 parent 2b578e4
commit 257be15
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/packages/puppeteer-core/src/cdp/Frame.ts b/packages/puppeteer-core/src/cdp/Frame.ts
@@ -21,7 +21,6 @@ import {Frame, FrameEvent, throwIfDetached} from '../api/Frame.js';
 import type {HTTPResponse} from '../api/HTTPResponse.js';
 import type {WaitTimeoutOptions} from '../api/Page.js';
 import {setPageContent} from '../common/util.js';
-import {assert} from '../util/assert.js';
 import {Deferred} from '../util/Deferred.js';
 import {disposeSymbol} from '../util/disposable.js';
 import {isErrorLike} from '../util/ErrorLike.js';
@@ -293,12 +292,12 @@ export class CdpFrame extends Frame {
   }
 
   #deviceRequestPromptManager(): DeviceRequestPromptManager {
-    if (this.isOOPFrame()) {
+    const parentFrame = this.parentFrame();
+    if (this.isOOPFrame() || parentFrame === null) {
       return this._frameManager._deviceRequestPromptManager(this.#client);
+    } else {
+      return parentFrame.#deviceRequestPromptManager();
     }
-    const parentFrame = this.parentFrame();
-    assert(parentFrame !== null);
-    return parentFrame.#deviceRequestPromptManager();
   }
 
   @throwIfDetached