fix(filechooser): cancel is sync (#6937)

BREAKING CHANGE: FileChooser.cancel() is now synchronous.
puppeteer · Mar 2, 2021 · 2ba61e0 · 2ba61e0
1 parent 0c26301
commit 2ba61e0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/docs/api.md b/docs/api.md
@@ -2790,7 +2790,6 @@ await fileChooser.accept(['/tmp/myfile.pdf']);
 - returns: <[Promise]>
 
 #### fileChooser.cancel()
-- returns: <[Promise]>
 
 Closes the file chooser without selecting any files.
 

diff --git a/src/common/FileChooser.ts b/src/common/FileChooser.ts
@@ -75,7 +75,7 @@ export class FileChooser {
   /**
    * Closes the file chooser without selecting any files.
    */
-  async cancel(): Promise<void> {
+  cancel() {
     assert(
       !this._handled,
       'Cannot cancel FileChooser which is already handled!'

diff --git a/test/input.spec.ts b/test/input.spec.ts
@@ -295,7 +295,13 @@ describe('input tests', function () {
       ]);
       await fileChooser.cancel();
       let error = null;
-      await fileChooser.cancel().catch((error_) => (error = error_));
+
+      try {
+        fileChooser.cancel();
+      } catch (error_) {
+        error = error_;
+      }
+
       expect(error.message).toBe(
         'Cannot cancel FileChooser which is already handled!'
       );