Skip to content

Commit

Permalink
chore: Useful error for Node v14 breakage
Browse files Browse the repository at this point in the history
There is currently a bug with extract-zip and Node v14.0.0 that
causes extractZip to silently fail:
#5719

Rather than silenty fail if the user is on Node 14 we instead
detect that and throw an error directing the user to that bug. The
rejection message below is surfaced to the user in the command line.

The issue seems to be in streams never resolving so we wrap the call in
a timeout and give it 100ms to resolve before deciding on an error. If
the user is on Node < 14 we maintain the behaviour we had before this
patch.

Here's how this change impacts the output on Node 14 and Node 10:

Node 10:

```
npm run tsc && rm -r .local-* && node install

> puppeteer@3.0.1-post tsc /Users/jacktfranklin/src/puppeteer
> tsc --version && tsc -p . && cp src/protocol.d.ts lib/ && cp src/externs.d.ts lib/

Version 3.8.3
Downloading Chromium r737027 - 118.4 Mb [====================] 100% 0.0s
Chromium (737027) downloaded to /Users/jacktfranklin/src/puppeteer/.local-chromium/mac-737027
```

---

Node 14 without this patch:

```
npm run tsc && rm -r .local-* && node install

> puppeteer@3.0.1-post tsc /Users/jacktfranklin/src/puppeteer
> tsc --version && tsc -p . && cp src/protocol.d.ts lib/ && cp src/externs.d.ts lib/

Version 3.8.3
Downloading Chromium r737027 - 118.4 Mb [====================] 100% 0.0s
```

Note that whilst it doesn't error, it doesn't complete the install. We
don't get the success message that we saw above in the Node 10 install.

---

Node 14 with this patch:

```npm run tsc && rm -r .local-* && node install

> puppeteer@3.0.1-post tsc /Users/jacktfranklin/src/puppeteer
> tsc --version && tsc -p . && cp src/protocol.d.ts lib/ && cp src/externs.d.ts lib/

Version 3.8.3
Downloading Chromium r737027 - 118.4 Mb [====================] 100% 0.0s
ERROR: Failed to set up Chromium r737027! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
Puppeteer currently does not work on Node v14 due to an upstream bug. Please see #5719 for details.
```

The explicit message should save users a good amount of debugging time.
  • Loading branch information
jackfranklin committed Apr 24, 2020
1 parent 1a4e260 commit 449da6c
Showing 1 changed file with 37 additions and 4 deletions.
41 changes: 37 additions & 4 deletions src/BrowserFetcher.ts
Expand Up @@ -321,10 +321,43 @@ function install(archivePath: string, folderPath: string): Promise<unknown> {
}

async function extractZip(zipPath: string, folderPath: string): Promise<void> {
try {
await extract(zipPath, {dir: folderPath});
} catch (error) {
return error;
const nodeVersion = process.version;

/* There is currently a bug with extract-zip and Node v14.0.0 that
* causes extractZip to silently fail:
* https://github.com/puppeteer/puppeteer/issues/5719
*
* Rather than silenty fail if the user is on Node 14 we instead
* detect that and throw an error directing the user to that bug. The
* rejection message below is surfaced to the user in the command
* line.
*
* The issue seems to be in streams never resolving so we wrap the
* call in a timeout and give it 100ms to resolve before deciding on
* an error.
*
* If the user is on Node < 14 we maintain the behaviour we had before
* this patch.
*/
if (nodeVersion === 'v14.0.0') {
await new Promise((resolve, reject) => {
let extractedResolved = false;
setTimeout(async() => {
await extract(zipPath, {dir: folderPath});
extractedResolved = true;
}, 10);

if (extractedResolved)
resolve();
else
reject(`Puppeteer currently does not work on Node v14 due to an upstream bug. Please see: https://github.com/puppeteer/puppeteer/issues/5719 for details.`);
});
} else {
try {
await extract(zipPath, {dir: folderPath});
} catch (error) {
return error;
}
}
}

Expand Down

0 comments on commit 449da6c

Please sign in to comment.