fix: check lifecycle comp. on same page navigation

puppeteer · May 13, 2022 · 6c86dd7 · 6c86dd7
1 parent 785abf4
commit 6c86dd7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/common/LifecycleWatcher.ts b/src/common/LifecycleWatcher.ts
@@ -225,7 +225,11 @@ export class LifecycleWatcher {
 
   _checkLifecycleComplete(): void {
     // We expect navigation to commit.
-    if (!checkLifecycle(this._frame, this._expectedLifecycle)) return;
+    if (
+      !this._hasSameDocumentNavigation &&
+      !checkLifecycle(this._frame, this._expectedLifecycle)
+    )
+      return;
     this._lifecycleCallback();
     if (
       this._frame._loaderId === this._initialLoaderId &&