chore: fix doclint issues (#5784)

puppeteer · Apr 30, 2020 · 7732d4c · 7732d4c
1 parent 530d6c7
commit 7732d4c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -4,6 +4,7 @@
   * [Getting Code](#getting-code)
   * [Code reviews](#code-reviews)
   * [Code Style](#code-style)
+  * [TypeScript guidelines](#typescript-guidelines)
   * [API guidelines](#api-guidelines)
   * [Commit Messages](#commit-messages)
   * [Writing Documentation](#writing-documentation)

diff --git a/utils/doclint/check_public_api/JSBuilder.js b/utils/doclint/check_public_api/JSBuilder.js
@@ -189,8 +189,8 @@ function checkSources(sources) {
    * @return {boolean}
    */
   function symbolHasPrivateModifier(symbol) {
-    const modifiers = symbol.valueDeclaration ? symbol.valueDeclaration.modifiers || [] : [];
-    return modifiers.some(modifier => modifier.kind && modifier.kind === ts.SyntaxKind.PrivateKeyword);
+    const modifiers = symbol.valueDeclaration && symbol.valueDeclaration.modifiers || [];
+    return modifiers.some(modifier => modifier.kind === ts.SyntaxKind.PrivateKeyword);
   }
 
   /**