fix: remove viewport conditions for waitForSelector

puppeteer · Oct 10, 2022 · 7882c57 · 7882c57
1 parent a032583
commit 7882c57
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 39 deletions.
diff --git a/packages/puppeteer-core/src/injected/util.ts b/packages/puppeteer-core/src/injected/util.ts
@@ -64,12 +64,5 @@ export const checkVisibility = (
 
 function isBoundingBoxVisible(element: Element): boolean {
   const rect = element.getBoundingClientRect();
-  return (
-    rect.width > 0 &&
-    rect.height > 0 &&
-    rect.right > 0 &&
-    rect.bottom > 0 &&
-    rect.left < self.innerWidth &&
-    rect.top < self.innerHeight
-  );
+  return rect.width > 0 && rect.height > 0 && rect.right > 0 && rect.bottom > 0;
 }
diff --git a/test/src/waittask.spec.ts b/test/src/waittask.spec.ts
@@ -25,7 +25,7 @@ import {
 } from './mocha-utils.js';
 import {attachFrame, detachFrame} from './utils.js';
 
-describe('waittask specs', function () {
+describe.only('waittask specs', function () {
   setupTestBrowserHooks();
   setupTestPageAndContextHooks();
 
@@ -537,38 +537,8 @@ describe('waittask specs', function () {
         Promise.race([promise, createTimeout(40)])
       ).resolves.toBeFalsy();
       await element.evaluate(e => {
-        e.style.setProperty('position', 'absolute');
-        e.style.setProperty('right', '100vw');
         e.style.removeProperty('height');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeFalsy();
-      await element.evaluate(e => {
-        e.style.setProperty('left', '100vw');
-        e.style.removeProperty('right');
-      });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeFalsy();
-      await element.evaluate(e => {
-        e.style.setProperty('top', '100vh');
-        e.style.removeProperty('left');
-      });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeFalsy();
-      await element.evaluate(e => {
-        e.style.setProperty('bottom', '100vh');
-        e.style.removeProperty('top');
-      });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeFalsy();
-      await element.evaluate(e => {
-        // Just peeking
-        e.style.setProperty('bottom', '99vh');
-      });
       await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be visible recursively', async () => {