Skip to content

Commit

Permalink
fix: add missing npm config environment variable (#8996)
Browse files Browse the repository at this point in the history
PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM can now also be specified from npm config by using it's lowercase variant
  • Loading branch information
dhirajgagrai committed Sep 22, 2022
1 parent 37417b1 commit 7c1be20
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/node/BrowserFetcher.ts
Expand Up @@ -38,7 +38,9 @@ import {assert} from '../util/assert.js';
import tar from 'tar-fs';
import bzip from 'unbzip2-stream';

const {PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM} = process.env;
const experimentalChromiumMacArm =
process.env['PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM'] ||
process.env['npm_config_puppeteer_experimental_chromium_mac_arm'];

const debugFetcher = debug('puppeteer:fetcher');

Expand Down Expand Up @@ -224,7 +226,7 @@ export class BrowserFetcher {
switch (this.#product) {
case 'chrome':
this.#platform =
os.arch() === 'arm64' && PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM
os.arch() === 'arm64' && experimentalChromiumMacArm
? 'mac_arm'
: 'mac';
break;
Expand Down

0 comments on commit 7c1be20

Please sign in to comment.