fix: bump chromium-bidi to a version that does not declare mitt as a …

…peer dependency (#9701)
puppeteer · Feb 17, 2023 · 82916c1 · 82916c1
1 parent 0f0401e
commit 82916c1
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 29 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json
@@ -131,6 +131,7 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "dependencies": {
+    "chromium-bidi": "0.4.4",
     "cross-fetch": "3.1.5",
     "debug": "4.3.4",
     "devtools-protocol": "0.0.1094867",
@@ -143,15 +144,11 @@
     "ws": "8.11.0"
   },
   "peerDependencies": {
-    "typescript": ">= 4.7.4",
-    "chromium-bidi": "0.4.3"
+    "typescript": ">= 4.7.4"
   },
   "peerDependenciesMeta": {
     "typescript": {
       "optional": true
-    },
-    "chromium-bidi": {
-      "optional": true
     }
   }
 }
diff --git a/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts b/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts
@@ -102,9 +102,9 @@ class CDPClientAdapter<
     this.#client.on('*', this.#forwardMessage as Handler<any>);
   }
 
-  #forwardMessage = (
-    method: keyof ProtocolMapping.Events,
-    event: ProtocolMapping.Events[keyof ProtocolMapping.Events]
+  #forwardMessage = <T extends keyof CdpEvents>(
+    method: T,
+    event: CdpEvents[T]
   ) => {
     this.emit(method, event);
   };