feat: support node 18

puppeteer · May 31, 2022 · 9c7e1a6 · 9c7e1a6
1 parent 9f9a1a4
commit 9c7e1a6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,7 +23,7 @@ jobs:
       matrix:
         # Include all major maintenance + active LTS + current Node.js versions.
         # https://github.com/nodejs/Release#release-schedule
-        node: [14, 16]
+        node: [14, 16, 18]
     steps:
       - name: Checkout
         uses: actions/checkout@v3

diff --git a/src/node/NodeWebSocketTransport.ts b/src/node/NodeWebSocketTransport.ts
@@ -16,9 +16,14 @@
 import NodeWebSocket from 'ws';
 import { ConnectionTransport } from '../common/ConnectionTransport.js';
 import { packageVersion } from '../generated/version.js';
+import { promises as dns } from 'dns';
 
 export class NodeWebSocketTransport implements ConnectionTransport {
-  static create(url: string): Promise<NodeWebSocketTransport> {
+  static async create(urlString: string): Promise<NodeWebSocketTransport> {
+    const url = new URL(urlString);
+    const { address } = await dns.lookup(url.hostname, { verbatim: false });
+    url.hostname = address;
+
     return new Promise((resolve, reject) => {
       const ws = new NodeWebSocket(url, [], {
         followRedirects: true,