fix: make sure discovery happens before auto-attach (#11100)

puppeteer · Oct 9, 2023 · 9ce204e · 9ce204e
1 parent b1eee92
commit 9ce204e
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/packages/puppeteer-core/src/cdp/ChromeTargetManager.ts b/packages/puppeteer-core/src/cdp/ChromeTargetManager.ts
@@ -127,14 +127,6 @@ export class ChromeTargetManager
       this.#onSessionDetached
     );
     this.#setupAttachmentListeners(this.#connection);
-
-    this.#connection
-      .send('Target.setDiscoverTargets', {
-        discover: true,
-        filter: this.#discoveryFilter,
-      })
-      .then(this.#storeExistingTargetsForInit)
-      .catch(debugError);
   }
 
   #storeExistingTargetsForInit = () => {
@@ -163,6 +155,13 @@ export class ChromeTargetManager
   };
 
   async initialize(): Promise<void> {
+    await this.#connection.send('Target.setDiscoverTargets', {
+      discover: true,
+      filter: this.#discoveryFilter,
+    });
+
+    this.#storeExistingTargetsForInit();
+
     await this.#connection.send('Target.setAutoAttach', {
       waitForDebuggerOnStart: true,
       flatten: true,