chore: don't use race for final condition

puppeteer · Sep 15, 2022 · a205f7b · a205f7b
1 parent fe255bc
commit a205f7b
Showing 1 changed file with 8 additions and 24 deletions.
diff --git a/test/src/waittask.spec.ts b/test/src/waittask.spec.ts
@@ -493,9 +493,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         e.style.removeProperty('display');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be visible (visibility)', async () => {
       const {page} = getTestState();
@@ -517,9 +515,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         e.style.removeProperty('visibility');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be visible (bounding box)', async () => {
       const {page} = getTestState();
@@ -572,9 +568,7 @@ describe('waittask specs', function () {
         // Just peeking
         e.style.setProperty('bottom', '99vh');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be visible recursively', async () => {
       const {page} = getTestState();
@@ -600,9 +594,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         return e.style.removeProperty('visibility');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be hidden (visibility)', async () => {
       const {page} = getTestState();
@@ -618,9 +610,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         return e.style.setProperty('visibility', 'hidden');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be hidden (display)', async () => {
       const {page} = getTestState();
@@ -636,9 +626,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         return e.style.setProperty('display', 'none');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be hidden (bounding box)', async () => {
       const {page} = getTestState();
@@ -654,9 +642,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         e.style.setProperty('height', '0');
       });
-      await expect(
-        Promise.race([promise, createTimeout(40)])
-      ).resolves.toBeTruthy();
+      await expect(promise).resolves.toBeTruthy();
     });
     it('should wait for element to be hidden (removal)', async () => {
       const {page} = getTestState();
@@ -672,9 +658,7 @@ describe('waittask specs', function () {
       await element.evaluate(e => {
         e.remove();
       });
-      await expect(
-        Promise.race([promise, createTimeout(40, true)])
-      ).resolves.toBeFalsy();
+      await expect(promise).resolves.toBeFalsy();
     });
     it('should return null if waiting to hide non-existing element', async () => {
       const {page} = getTestState();